Skip to content

Resolve "Update TransmissionRequests: Modal when sending payload"

Carlos Sanchez requested to merge 516-update-transmissionrequests-modal-when-sending-payload into main

Closes #516 (closed)

To achieve this I used the WaitAndCancelModal which already exists and mostly does what we want.
But this lead to some code changes which do not look too clean. Therefore I have questions:

  • Should I use WaitAndCancelModal or should I create another SessionSendModal which is mostly copied over code? This would mean to create it for bengal as well as default theme.
  • Should I try to get rid of iconPath - it makes the code a lot more ugly and imho would not be necessary as we can add the icons to the ready-icons we would need to overwrite which icon is used by flavor then.
  • Or is it ok as it is?

Merge request reports