Request for comments: Suggestion for how to redesign template page DON'T MERGE
Request for comments
As the issue was timeboxed for four hours, this is a RFC for a potential solution to the issue
About the solution
- I created a new module, with a component for the current monitoring-setup layout, calling it questionnaire-editor
- This component would be used by both monitoring-setup-page, and symptom-check-edit-page
- Component takes inputs for the template ID (for both the
from
andedit
routes) - Component takes input as to whether the template name should derive from the template chosen (defaults to false)
- Component takes input of a confirmation action
What's left to do
- The new component should be used by
monitoring-setup-page
(and the old unused components now deleted) - the save template action should be handled
- test that it works for all four scenarios
Ref: #514 (closed)
Edited by James Jenkinson
Merge request reports
Activity
changed milestone to %Sprint CW24.2023
added Variant: HCP label
assigned to @james-jenkinson
Closing this merge request for now
After conversation with Andreas:
- The proposed solution is okay
- We should make sure to keep the old layout in a module
- If there's time at the end of this sprint, we can implement it within this sprint, otherwise it'll get pushed to the next
Edited by James Jenkinson
Please register or sign in to reply