Resolve "B_020_R1 Fix General Question: Default Notes question"

Closes #1264 (closed)

Issue was:

The wording of the daily notes question changes upon transmission from HCP to PAT.

HCP wording (desired): What else happened today?

PAT wording: Daily notes

Reason:

There are 2 questions with the same ID DAILY_NOTES_ID: In CuratedDefaultQuestionStoreService (HCP wording) and in StarterQuestionStoreService (PAT wording). On transmission, ImportQuestionStoreService.addQuestionConfig() only adds transmitted questions if their ID isn't in the QuestionnaireService. Since the daily notes question is in PAT by default (via StarterQuestionStoreService), nothing is added/updated.

Fix:

Delete daily notes from StarterQuestionStoreService.

Import CuratedDefaultQuestionStoreServiceModule (which includes the daily notes) in PAT base features.

In testing, the behavior was the same as before except for the wording switch. The daily notes are still 1 question that is shared across all symptom checks.

Don't forget to import MockRccPublicRuntimeConfigModule into RccBaseFeaturesModule

changed milestone to %Sprint CW36.2024

added Bug Priority: Deployment Priority: High SP:3 Variant: Pat Variant: Pat-Med labels

assigned to @noel.simmel

added 2 commits

• 1839cce1 - Delete daily notes from starter SC and import curated questions instead
• bf33a89e - Update e2e tests

Compare with previous version

marked this merge request as ready

changed the description

requested review from @carlos

LGTM. Actually, by testing this issue, I found one little problem with the categories in the daily run query!

approved this merge request

merged

mentioned in commit 811702b5

resolved all threads