Skip to content

Resolve "QR-Code not getting refreshed"

Andreas Pittrich requested to merge 932-qr-code-not-getting-refreshed-2 into main

Closes #932 (closed)

The reason for the bug was a an Object that looked like a Promise but in fact was none (UserCancel implements PromiseLike). When that PromiseLike was later used as a promise ZoneJs could not handle it like it handles Promises and it wouldn't properly trigger the angular promise/event/change resolution.

So I used firstValueFrom() to turn UserCancel into an actual promise 😄

The file I changed needs lots of linting, but fixing the types is a rather extensive endeavor and when I tried I messed things up, so that the transmission stopped working. Fixing the types properly requires a bit of a rewrite and I would rather move that to a future task instead of doing it on the fly for a bug fix. That's why I skipped the linting part of the pipeline and would suggest to merge things as they are.

Edited by Andreas Pittrich

Merge request reports