Skip to content

Resolve "Broken Monitoring set-up"

Andreas Pittrich requested to merge 900-broken-monitoring-set-up into main

Closes #900 (closed) Closes #885 (closed)

I fixed three closely connected issues with the monitoring setup:

  1. Opening the monitoring setup, canceling it and opening it again did not correctly trigger edit mode.
  1. Switching to preview mode triggered ExpressionChangedAfterItHasBeenCheckedError
  • I turned some complex getters into values that get updated only when need be (since getters are prone to the above error and the same object was created 160+ times :D)
  • I added ChangeDetectorRef, since ultimately some dynamic component (a querywidget) was added when an observable emitted, which can happen outside the CD-loop.
  1. A faulty SymptomCheckConfig-check prevented a template from being stored at the end of the monitoring setup.

You can see the bugs on qa.hcp.recoverycat.de (for now)

  1. Open monitoring setup, select template, navigate back to home; open monitoring setup again, pick template => questions are not editable
  2. Switch to preview mode, check console.
  3. Goto Templates (Vorlage) via main menu, click a template, switch to preview, try to save => nothing happens (check sonsole)
Edited by James Jenkinson

Merge request reports

Loading