Skip to content

#779 - solution 1: Replace angular lifecycle hooks with ionic

James Jenkinson requested to merge 779-serious-bug-dayqueryrunpagecomponent-not-getting-destroyed-leads-to-new-questions-not-beeing into main

@rhotep , how is this solution?

The fact that the component isn't destroyed when it's navigated away from isn't something that we can do anything about unfortunately, at least not while we're still using ionic's router, that's just how the ionic router works.

Ionic however comes with its own lifecycle hooks (which we should probably be generally using for route level components destroy methods)

The big downside here is that if and when we move away from ionic's router, we'll need to replace these hooks with angular's in-built hooks, however, given that they're prefixed with ion they should be easy to find

I don't know if there's any issue or milestone anyway for getting rid of ionic, I didn't look into how much effort it would be to replace out the ionic router, possibly it's not too much 🤔

Closes #779 (closed)

Merge request reports