Skip to content

Resolve "High Priority: Home in-use page: Item tags on homescreen TODO"

Andreas Pittrich requested to merge 754-high-priority-home-in-use-page-item-tags-on-homescreen-todo into main

Closes #754

It took me too long to write the issue properly, so instead I did it myself :D

I added ItemActions for open Sessions. open session were already added to the home screen, but only had the export action (which they should not display onthe homescreen).

So I went on to add:

  • an ItemAction to close an open session (after confirmation) (at OpenSessionModule)
  • an ItemAction to open the session home page with the item loaded (at SessionHomePageModule)

I had to update the OpenSessionStoreService, such that a session that is already activated, can be activated a second time. Activating a session marks it as active and triggers navigation to the session home page. Prior to the changes there was no place other than that page to activate a session, so there was no need to navigate to the session home, as you were already there (for that reason activating wouldn't work for an already active session).

I added itemActionsRoles property to ItemEntrys for the Homepage. This allows to filter the itemActions of ItemEntries on the homepage. It set it to 'destructive' (for closing the session, aka removing it from the OpenSessionStoreService) and 'edit' because the session home page is meant among other things to edit the symptomcheck of a session. (a bit odd, but couldn't find abetter role).

I also updated the styles of standalone item tags such that the ItemEntries on the Homepage look as planned. I changed things quite a lot, I'm really sorry about that, I didn't mean to disrespect your code, but I am in quite the hurry, and couldn't wrap my head around how to combine the previous state with the the layout for small screen ItemEntries on the homepage without breaking thing on various resolutions.

How to Test?

Open HCP and send one set of data to the HCP from the PAT. This hsould trigger the session home page -> close it and you should see the open session at the bottom ofthe homepage 😄

Layouts not 100%

Please disregard minor differences to the layouts. It's important that we get things into a state where we can manually test things, so everything is a bit rushed =/. If the layout should break somehow, that's another issue :)

Edited by Andreas Pittrich

Merge request reports