Skip to content

Make report stacked view not depend on curated questions

Andreas Pittrich requested to merge make-report-stacked-view-not-depend-on-curated-questions into main

I stumbled across this when working on another issue: ReportStackedViewComponent needs to get the daily-notes-question and therefor tries to get it from its original stored DefaultCurated... And that in turn makes the parent module ReportStackedViewModule depend on DefaultCurated.

That though means that whenever a variant uses the stacked view, it will also load the all the default curated questions. Which is not intended.

So I replaced the DefaultCurated... with QuestionnaireService. The latter one gives access to all questionsincluding the ones in DefaultCurated... If DefaultCurated... is not included in the build the daily-notes question will not be available to the user – unless received from the e.g. the HCP. In that case the daily-notes-question will be in the ImportedQuestionStore which is also part of QuestionnaireService.

I'm concerned that I might undo the fixes of !589+ with this

But everything seems fine to me, can you take a look @fupduck?

Edited by Andreas Pittrich

Merge request reports