Skip to content

Resolve "NEW: Websocket Update"

James Jenkinson requested to merge 483-new-websocket-update into main

Bug with [undefined]

See comment here

Basically as the previous setting was set to be multi-select, with both possible values, the pull down doesn't show the selected options correctly.

This also results in a user, who:

  • previously opened the app when the setting was multi select
  • Didn't change the default app
  • Now receives the new app version

Will still see [undefined] in the select box, not understanding why.

However, given that:

  • this bug would be resolved as soon as the user chose a value
  • Probably very few users will ever change this setting

imo it's not a bug that's worth fixing.

However comment if you see that differently

Divergence from designs

see comment here

The designs show these options as one, however it was decided we'll keep them as they currently are, as two different options, with the same copy.

As such all that was needed here was to add the modal button as well to the second option

Closes #483

Edited by James Jenkinson

Merge request reports

Loading