Skip to content

Resolve "Add translation Filter pipe"

Andreas Pittrich requested to merge 445-add-translation-filter-pipe into main

Closes #445 (closed)

This one is rather old. Its main purpose is to be used in rcc-pull-down-select. But recently we also need it in various other places where we want to filter lists of items that need translations. For the most part we just disabled filtering for the moment, this MR enables us to reintroduce filtering based on translations, without adding extra logic to the components.

The main new thing is RccMutateByTranslationPipe. Since it does multiple things in a row, translate, sort, filter, map to original object, I split things up into multiple operators, so concerns stay separate. Also some of these operators will be reused for an upcoming groupByTranslationPipe.

RccTranslatePipe and RccFillePipe are not new. They used to be in the same file (translations.pipes) by I split them up added a few lines of documentation and did some linting.

I had to remove a couple of console.logs in the tests, and then the linter complained -> that's why there are changes to the translator files.

Edited by Andreas Pittrich

Merge request reports

Loading