Skip to content

PreWork: Resolve "Enable Transmission Request #863fwpt2d #863fwptf5"

Andreas Pittrich requested to merge 333-prework into main

I got carried away when working on #333 (closed). So this is an attempt of breaking the large upcoming MR into smaller parts.

Here is the prework for !268 it is still rather large, sorry =/

There is two mayor areas of change: The Settings and the Transmissions

Transmissions

  • TransmissionService now can me initialized for sending with existing transmission meta data. Previously when sending it always generated it's own unique meta data known to noone else unless shared.
  • The Main RccTransmissionService now checks if a Transmission service is allowed and if not asks for a one-time confirmation if the app tries to use a transmission service for sending or receiving. The settings will not be changed and the confirmation counts only for one attempt. (Since QR-Codes now can trigger the confirmation, I felt the need to be more restrictive)

Settings

  • Settings that can have multiple values (like allowed receiving services) now always store an array, even if only one service was selected.
  • Setting groups can now have an introduction component, that is shown at the top of the group setting page. (Check the Transmission settings)
  • Group Entries are now entries with ```.type = 'group'``. And groups can be part of other groups recursively. They can be provided just like other SettingEntries.

Decoupled RccTransmissionModule and transmission settings

  • RccTransmissionModule now works without Settings (everything is allowed)
  • Only if the TransmissionSettingsModule is loaded restrictions take effect an can be changed in the settings.

Merge request reports