Skip to content

Resolve "A_019 Navigation menu refactor | Step 2: Close menu X"

Hanhoan Truong requested to merge 1195-a_019-navigation-menu-refactor-step-2-close-menu-x into 1267-a_019-navigation-menu-refactor-overview-and-main-epic-branch

  • This builds on the changes of #1265 (closed)

  • The x-close button is now on a div outside of the main menu container that is placed over the page (on the y-axis) while being pushed out of that container down on the position of the hamburger.

  • That invisible close button container behaves the same way the full page centered-content container does.

  • Thus the closebutton is always on top of the hamburger button but is only shown when the main menu is open.

  • It has no 'slide in from the right'-animation which is at the moment the trade off.

-cI had to tweak the main menu resizing behavior to look good on various screen sizes, so the close button moves slightly in relation to the main menu options, but that is a minor inconvenience.

Closes #1195 (closed)

Edited by Hanhoan Truong

Merge request reports