Resolve 1211-static-qr-code-general-questions
Updated August 9, 2024
- E2E tests branch was merged.
- Minor fix to nginx config to get proper http codes when testing. New test was failing saying the server responded with 404.
- E2E run: https://git.recoverycat.de/recoverycat/rcc-client/-/pipelines/14137
Updated August 8, 2024
- Validations were added https://git.recoverycat.de/recoverycat/rcc-knowledge-base/-/blob/main/projects/static-qr-code/static-qr-code.md#error-examples
- Error codes were added: https://git.recoverycat.de/recoverycat/rcc-knowledge-base/-/blob/main/projects/static-qr-code/static-qr-code.md#error-messages-and-codes
- Runtime config has been added for qa
- Mock module has been removed: https://git.recoverycat.de/recoverycat/rcc-knowledge-base/-/blob/main/projects/static-qr-code/static-qr-code.md#how-to-test-it-locally
- More unit tests were added based on the new validations.
- Key comments were added
- General E2E test work well: https://git.recoverycat.de/recoverycat/rcc-client/-/pipelines/14105
- E2E is being worked on and will be part of the same issue but as a different MR.
Tangential finding:
- Toasts don't react to language change, but out of scope for this ticket, see bug report: #1232 (closed)
Updated August 2, 2024
- The runtime configuration has been established and can be tested: https://git.recoverycat.de/recoverycat/rcc-knowledge-base/-/blob/main/projects/static-qr-code/static-qr-code.md#how-to-test-it-locally
- More validations are being added and error messages will be improved: https://git.recoverycat.de/recoverycat/rcc-knowledge-base/-/blob/main/projects/static-qr-code/static-qr-code.md#error-examples
- First E2E will be worked on next week.
- Runtime config has been added for dev, we may want to remove the mock module now.
How to test
PAT: Generally testable via base64 string, that I printed out in the console.
HCP: Check out if the template + the questions exist. Also check if the question widget was chosen as desired.
About tests
Unit tests still missing but technically no new functionality was added.
E2E tests. Not sure if they make sense at this stage, as the QR code functionality has not been implemented yet. (user journey not complete)
Closes #1211 (closed)
Edited by Carlos Sanchez