Skip to content

Update ModalWithResultComponent

ModalWithResultComponent needs a small overhaul:

  • We should move modal-with-result-component.ts to @rcc/common/src/overlays I was ill-advised placing it into @rcc/common/src/modal-providers as that folder should be reserved for providing the most basic infrastructure/interfaces for modals and the like. (also poorly named by me *sigh*)
  • Add a new abstract class ItemEditModalComponent<I extends Item, Artifacts = never> extending ModalWithResultComponent<ItemEditResult<I,Artifacts>>, and that abstract class should then have a property .item : I -> place into @rcc/common/src/items/edit
  • Add an abstract (or static?) method .assertResult(x:unknown) : ItemEditResult<I,Artifacts> to ItemEditModalComponent<I, Artifacts = never> that checks and asserts if a value actually conforms to the interface.
  • And at last: add a call to the new method to ItemEditService.editCopy()